Open
Conversation
Contributor
Author
|
This does place some additional restrictions on the typing... we'll no longer be able to:
I think having a |
src/Boolean.php
Outdated
| if ($value === null) { | ||
| throw new InvalidArgumentException('Value must be boolean'); | ||
| } | ||
| $assert = that($value)->boolean(); |
Using `beberlei/assert` to simplify validation. This does not help with boolean type casting.
shadowhand
force-pushed
the
fix/use-assert
branch
from
e661690 to
2c7934e
Compare
Contributor
Author
|
@equip/contributors all good? |
|
👍 |
| if (!is_scalar($value)) { | ||
| throw new InvalidArgumentException('Value must a possible boolean'); | ||
| } | ||
| that($value)->nullOr()->scalar(); |
There was a problem hiding this comment.
personally I think it reads better as Assertion::that($value)->nullOr()->scalar();
"that" by itself seems to lack some context. If you want to keep the use maybe alias it?
Contributor
Author
There was a problem hiding this comment.
I don't agree, there is a clear use function at the top of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
beberlei/assertto simplify validation.This does not help with boolean type casting.