feat(simplecrud): add CancellationToken overloads;#280
Open
tpayne84 wants to merge 1 commit intoericdc1:masterfrom
Open
feat(simplecrud): add CancellationToken overloads;#280tpayne84 wants to merge 1 commit intoericdc1:masterfrom
tpayne84 wants to merge 1 commit intoericdc1:masterfrom
Conversation
…ers; default token is null * Add `CancellationToken?` overloads for: * `GetAsync`, `GetListAsync` (object & string conditions), `GetListPagedAsync`, * `InsertAsync` (`int?` and generic `TKey`), `UpdateAsync`, * `DeleteAsync`, `DeleteListAsync`, and `RecordCountAsync`. * Set overload defaults to `CancellationToken? token = null`. * Extract shared SQL construction into private helpers returning `StringBuilder`/`string` to reduce duplication. * Disambiguate reflection for generic `InsertAsync<TKey, TEntity>` by filtering on parameter count (4-param vs 5-param). * Update tests to call explicit-arg overloads and add coverage for token-enabled paths. *No breaking changes: existing method signatures remain intact;*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
CancellationToken?overloads for:GetAsync,GetListAsync(object & string conditions),GetListPagedAsync,InsertAsync(int?and genericTKey),UpdateAsync,DeleteAsync,DeleteListAsync, andRecordCountAsync.Set overload defaults to
CancellationToken? token = null.Extract shared SQL construction into private helpers returning
StringBuilder/stringto reduce duplication.Disambiguate reflection for generic
InsertAsync<TKey, TEntity>by filtering on parameter count (4-param vs 5-param).Update tests to call explicit-arg overloads and add coverage for token-enabled paths.
No breaking changes: existing method signatures remain intact;