txnprovider/shutter: follow up update for EIP-8037#21399
Merged
Conversation
AskAlexSharov
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the
TODO(yperbasis): revisit Shutter gas filtering for EIP-8037intxnprovider/shutter/pool.go.Why
The Shutter pool previously used
txn.GetGasLimit()as a conservative proxy for both regular and state gas dimensions because it lacked access to the chain config needed to compute intrinsic gas. Two problems:availableGas.RegularandavailableGas.State, and rejected any txn whose gas limit exceeded either dimension — even when the actual intrinsic state gas was 0 (e.g., simple transfers).best(), which already filters by per-dimension intrinsic gas under EIP-8037.What
*chain.Configtoshutter.NewPoolso it can resolve fork flags from block time.gasLimit-as-proxy filter with EIP-8037-aware per-dimension intrinsic gas filtering, matchingtxpool.best():mdgas.IntrinsicGaswith the right fork flags (EIP-3860 / 7623 / 7976 / 7981 / 8037).intrinsicRegularGasagainstavailableGas.RegularandintrinsicGasResult.StateGasagainstavailableGas.Stateindependently.applyTransactionin the block assembler.Warnlogs at every skip branch (overflow, insufficient regular / state / blob gas) with txnhash,type,sender, plus the relevant intrinsic and available gas values for the failing dimension.TestPoolProvideTxnsFiltersByIntrinsicGasNotFullGasLimit— verified red against the previous code and green against the fix.Test plan
go test ./txnprovider/shutter/...make lintmake erigon