[DO-NOT-MERGE] execution: hive eest ci to include all devnet shards#21404
Open
taratorio wants to merge 7 commits into
Open
[DO-NOT-MERGE] execution: hive eest ci to include all devnet shards#21404taratorio wants to merge 7 commits into
taratorio wants to merge 7 commits into
Conversation
Member
Author
|
let's wait for 1 Hive EEST job run before merging: https://github.com/erigontech/erigon/actions/runs/26396228185 |
Member
Author
all green in 31mins, should be good to go |
Member
Author
2nd run had a flake, will investigate first before merging, let's hold off |
AskAlexSharov
approved these changes
May 26, 2026
…e-eest-full-devnet-shards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The previous
glamsterdam-devnetshard filtered--sim.limitby the specific BAL-era EIP numbers (7708|7778|7843|7928|7954|7976|7981|8024|8037). That kept the shard fast, but it skipped every test in theeest_devnetfixtures that wasn't on that EIP list — including ~19k regenerated previous-fork tests (Paris/Shanghai/Cancun/Prague/Osaka) that exist precisely to verify those forks still pass under Amsterdam-era state changes. We were not exercising any of them in CI.This PR closes that gap: full per-fork coverage of
eest_devnet, every shard under the 30-min CI budget.What
Replace the single EIP-filtered
glamsterdam-devnetshard with 7 devnet shards mirroring theeest_stableper-fork split, plus two splits forced by what we found while bringing it up:paris-devnet.*/.*fork_Parisshanghai-devnet.*/.*fork_Shanghaicancun-devnet.*/.*fork_Cancunprague-devnet.*/.*fork_Pragueosaka-devnet.*/.*fork_Osakaamsterdam-a-l-devnet.*tests/[a-l].*fork_Amsterdamamsterdam-m-z-devnet.*tests/[m-z].*fork_AmsterdamMeasured locally against
bal@v7.2.0/devnets/bal/7, shards run sequentially. In CI they run in parallel, so wall time is bounded by the longest shard (~26 min).*
amsterdam-a-l-devnetwas verified separately with 0 failures, but the EIP-7928test_bal_invalid_extraneous_entriesflake (#21364) fired once during the combinedfork_Amsterdamrun that produced the totals row. The flake lives intests/amsterdam/...so it falls in the[a-l]half — hence themax-failures: 1budget there.Two splits worth calling out
paris-devnetandshanghai-devnetare separate shards (instead of oneparis+shanghai-devnetmirroring stable). The consume-engine plugin ondevnets/bal/7does not honour regex alternation in--sim.limit: empirically,".*/.*fork_(Paris|Shanghai)"leaks ~5.8kfork_Cancuntests into the shard (verified by inspecting thetestCasesJSON). Single-fork patterns filter correctly. Worth chasing upstream, but splitting unblocks us today.fork_Amsterdamis split into two shards by first-directory letter undertests/([a-l]vs[m-z]). The combined shard ran ~21k tests in ~52 min, over the 30-min target. The letter split gives a ~52/48 partition; both halves measured under 26 min locally. Character-class regex was verified locally to filter exactly (no leakage between halves).Failure budget
amsterdam-a-l-devnetcarriesmax-failures: 1for the EIP-7928test_bal_invalid_extraneous_entriesflake (#21364) — the test lives intests/amsterdam/...so it falls in the[a-l]half. Every other devnet shard ismax-failures: 0.Docs
.claude/skills/hive-test/SKILL.mdupdated to match the new shard list, max-failures table, and the alternation/letter-split rationale.