Fix query_snapshots schema mismatch after sp_WhoIsActive upgrade#401
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 3, 2026
Merged
Fix query_snapshots schema mismatch after sp_WhoIsActive upgrade#401erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
…grade sp_WhoIsActive inserts into destination tables by ordinal position, not column name. When sp_WhoIsActive is updated and its output column order changes, existing daily tables (query_snapshots_YYYYMMDD) have the old column order, causing "Implicit conversion from data type xml to varchar" errors until the next day when a new table is created. Fix: wrap the insert in a nested TRY/CATCH. On error 257 (implicit conversion), drop and recreate the daily table from the current sp_WhoIsActive schema, then retry the insert. This makes upgrades work immediately without waiting for midnight table rotation. Tested on sql2017, sql2019, sql2025 — all had the error before, all pass clean after this fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CPUmoved from position 19 to 9), existing daily tables have the old layoutImplicit conversion from data type xml to varchar is not allowederrors for the rest of the day until midnight creates a new tableTest plan
🤖 Generated with Claude Code