This repository was archived by the owner on Jun 2, 2018. It is now read-only.
Open
Conversation
Owner
|
Wow this is awesome! I'll take a look at it when I get home tonight 😃 |
Author
|
Great, In the meantime, this is what I think it is still needed on this branch, feel free tonight to add your checkboxes ;)
Best |
Author
|
Hi there, I suppose you did not had time to have a look yet at my implementation. This is still a mess, but I think I have yet something quite functional here: http://guillaumepotier.github.io/2048-multiplayer/ Best |
- added config file to handle different configs (local / prod). Removed ambiguous characters from hashes. Need to fix now actions after game over. - added missing redis from package.json for server. Fixed indent. need to seriously work out new game after first finished game - some more hacks not very UX/UI friendly to make successive games working.. need better implem - variabilized get server info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @emils,
First of all, thanks for your great 2048 multiplayer version! I'm using it a lot and having much fun with colleagues :)
I'm implementing a "Play with a friend" feature, much needed for us (currently, we savagely refresh browsers to try to find against each others..) on your code. Here is my first commit.
Here, basically, what I have done:
This is working for me right now.
Now, what I'd like if possible:
Best :)