feat: add ESM entrypoint and TypeScript exports#146
Open
luzzwaix wants to merge 2 commits intoesatterwhite:mainfrom
Open
feat: add ESM entrypoint and TypeScript exports#146luzzwaix wants to merge 2 commits intoesatterwhite:mainfrom
luzzwaix wants to merge 2 commits intoesatterwhite:mainfrom
Conversation
e114962 to
3bec3a4
Compare
3bec3a4 to
6652b79
Compare
Owner
|
I'll refer you to this comment What problem are we actually trying to solve here? |
Author
@algora-pbc /claim #135 Thanks, that makes sense. I narrowed the PR around the problem you described in the earlier comment. The goal here is not to migrate the project to TypeScript or make ESM the primary runtime format. CommonJS remains the implementation and there is still no build step. This now focuses on:
I removed the separate ESM shim and kept the runtime surface closer to the existing package design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@algora-pbc /claim #135
Closes #135.
Adds package-level ESM and TypeScript support while preserving CommonJS compatibility.
Verification: