Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 7, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR was motivated by #253.

In this PR, I've primarily updated @html-eslint/eslint-plugin to 0.50.0.

The CI failed because of newly updated types in @html-eslint/eslint-plugin, so I've opened a separate PR:

https://github.com/eslint/code-explorer/actions/runs/19939229918/job/57172393803?pr=253

image

Based on the core Plugin type, including undefined in the @html-eslint/eslint-plugin type appears to be valid.

https://github.com/eslint/rewrite/blob/main/packages/core/src/types.ts#L1114-L1125

export interface Plugin extends ObjectMetaProperties {
	meta?: ObjectMetaProperties["meta"] & {
		namespace?: string | undefined;
	};
	configs?:
		| Record<string, LegacyConfigObject | ConfigObject | ConfigObject[]>
		| undefined;
	environments?: Record<string, EnvironmentConfig> | undefined;
	languages?: Record<string, Language> | undefined;
	processors?: Record<string, Processor> | undefined;
	rules?: Record<string, RuleDefinition> | undefined;
}

Also, I’ve updated React to the latest version and used the node: prefix in vite.config.ts to clarify the code’s intent.

What changes did you make? (Give an overview)

In this PR, I've primarily updated @html-eslint/eslint-plugin to 0.50.0.

Related Issues

Ref: #253

Is there anything you'd like reviewers to focus on?

N/A

@netlify
Copy link

netlify bot commented Dec 7, 2025

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 9be4db5
🔍 Latest deploy log https://app.netlify.com/projects/eslint-code-explorer/deploys/69350f89b9b4ea0008f5c596
😎 Deploy Preview https://deploy-preview-260--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslintbot eslintbot added this to Triage Dec 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 7, 2025
@lumirlumir lumirlumir changed the title chore: update @html-eslint/eslint-plugin chore: update @html-eslint/eslint-plugin to 0.50.0 Dec 7, 2025
case "html": {
const { templateEngineSyntax, frontmatter } = htmlOptions;
const language = html.languages.html;
const language = html.languages!.html;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used the non-null assertion since, unlike in the type implementation, it's obvious that html.languages is not undefined in the real implementation.

@lumirlumir lumirlumir marked this pull request as ready for review December 7, 2025 05:34
Copilot AI review requested due to automatic review settings December 7, 2025 05:34
@lumirlumir lumirlumir requested a review from a team December 7, 2025 05:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates @html-eslint/eslint-plugin from version 0.48.0 to 0.50.0, with necessary type adjustments to accommodate breaking changes in the plugin's type definitions. Additionally, React and React DOM are updated to the latest patch version 19.2.1.

  • Updated @html-eslint/eslint-plugin to 0.50.0 with corresponding type safety fix
  • Updated React and React DOM to 19.2.1
  • Improved code clarity with node: prefix for Node.js built-in module imports

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
vite.config.ts Added node: prefix to path import for better Node.js built-in module clarity
src/hooks/use-ast.ts Added non-null assertion operator for html.languages property to comply with updated type definitions from @html-eslint/eslint-plugin v0.50.0
package.json Updated @html-eslint/eslint-plugin to 0.50.0 and React/React DOM to 19.2.1
package-lock.json Synchronized dependency tree with package.json changes, including transitive dependency updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@amareshsm amareshsm merged commit bd98b27 into main Dec 8, 2025
15 checks passed
@amareshsm amareshsm deleted the chore-update-html-eslint branch December 8, 2025 06:01
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants