-
-
Notifications
You must be signed in to change notification settings - Fork 17
chore: update @html-eslint/eslint-plugin to 0.50.0
#260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@html-eslint/eslint-plugin@html-eslint/eslint-plugin to 0.50.0
| case "html": { | ||
| const { templateEngineSyntax, frontmatter } = htmlOptions; | ||
| const language = html.languages.html; | ||
| const language = html.languages!.html; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used the non-null assertion since, unlike in the type implementation, it's obvious that html.languages is not undefined in the real implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates @html-eslint/eslint-plugin from version 0.48.0 to 0.50.0, with necessary type adjustments to accommodate breaking changes in the plugin's type definitions. Additionally, React and React DOM are updated to the latest patch version 19.2.1.
- Updated
@html-eslint/eslint-pluginto0.50.0with corresponding type safety fix - Updated React and React DOM to
19.2.1 - Improved code clarity with
node:prefix for Node.js built-in module imports
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vite.config.ts | Added node: prefix to path import for better Node.js built-in module clarity |
| src/hooks/use-ast.ts | Added non-null assertion operator for html.languages property to comply with updated type definitions from @html-eslint/eslint-plugin v0.50.0 |
| package.json | Updated @html-eslint/eslint-plugin to 0.50.0 and React/React DOM to 19.2.1 |
| package-lock.json | Synchronized dependency tree with package.json changes, including transitive dependency updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amareshsm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Prerequisites checklist
What is the purpose of this pull request?
This PR was motivated by #253.
In this PR, I've primarily updated
@html-eslint/eslint-pluginto0.50.0.The CI failed because of newly updated types in
@html-eslint/eslint-plugin, so I've opened a separate PR:https://github.com/eslint/code-explorer/actions/runs/19939229918/job/57172393803?pr=253
Based on the core
Plugintype, includingundefinedin the@html-eslint/eslint-plugintype appears to be valid.https://github.com/eslint/rewrite/blob/main/packages/core/src/types.ts#L1114-L1125
Also, I’ve updated React to the latest version and used the
node:prefix invite.config.tsto clarify the code’s intent.What changes did you make? (Give an overview)
In this PR, I've primarily updated
@html-eslint/eslint-pluginto0.50.0.Related Issues
Ref: #253
Is there anything you'd like reviewers to focus on?
N/A