Open
Conversation
1 task
DMartens
reviewed
Feb 18, 2026
DMartens
reviewed
Feb 18, 2026
Member
|
@sethamus there are some comments to review. |
DMartens
reviewed
Mar 10, 2026
src/rules/sort-keys.js
Outdated
| includeComments: true, | ||
| }); | ||
|
|
||
| if (after?.type === "Comma") { |
There was a problem hiding this comment.
You should use the filter method for sourceCode.getTokenAfter.
Contributor
Author
There was a problem hiding this comment.
JSONSourceCode doesn't support the filter option for getTokenAfter/getTokenBefore. I can open a separate PR to add support for it.
DMartens
reviewed
Mar 10, 2026
DMartens
reviewed
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR adds autofix support to
sort-keysso eslint can automatically reorder object keys, while avoiding fixes that could detach/misplace comments.What changes did you make? (Give an overview)
sort-keysas fixable and implemented a fixer that swaps out-of-order adjacent members.Related Issues
Fixes #122
Is there anything you'd like reviewers to focus on?