Skip to content

fix(test): remove duplicate on_file_select call causing flaky CI #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esmuellert merged 1 commit into from
Mar 7, 2026
Merged

fix(test): remove duplicate on_file_select call causing flaky CI #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions tests/ui/explorer/hunk_operations_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,13 +338,10 @@ describe("Hunk operations (side-by-side)", function()
local tabpage, session, explorer = open_codediff_and_wait(repo)
local lifecycle = require("codediff.ui.lifecycle")

-- Select the file in the staged group
explorer.on_file_select({
path = "file1.txt",
status = "M",
git_root = repo.dir,
group = "staged",
})
-- The explorer auto-selects file1.txt in the "staged" group because
-- all changes are staged and there are no unstaged files. We just
-- wait for that async selection to finish rather than issuing a
-- duplicate on_file_select call that would race with the auto-select.

-- Wait for staged view (modified_revision == ":0") and 2 hunks
local staged_ready = vim.wait(8000, function()
Expand Down