fix(keymaps): guard nil changes in find_hunk_at_cursor#315
Merged
esmuellert merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
find_hunk_at_cursor() crashed with 'attempt to get length of field changes (a nil value)' when stored_diff_result existed but its .changes field was nil (e.g. after single-pane views or during async transitions). Add a nil check before accessing #diff_result.changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
E5108: Lua: attempt to get length of field 'changes' (a nil value)crash infind_hunk_at_cursor()when invoking hunk operations (stage/unstage/discard) whilestored_diff_result.changesis nil.Root Cause
find_hunk_at_cursor()checked#diff_result.changes == 0without first verifying.changesis non-nil. This crashes whenstored_diff_resultexists but.changesis nil — the same class of bug fixed in PR #313 forrender_diff().Changes
if not diff_result.changes or #diff_result.changes == 0 thenTesting
.changesis present