feat(pagination): add pagination to the entries page since the list was getting too huge#140
Merged
samoehlert merged 16 commits intomainfrom Apr 10, 2025
Merged
Conversation
…as getting too huge
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 304fc19 |
…this commit ruff is complaining about dict comprehensions. also pull in the other changes to get us caught up
…curity/SCRAM into topic/soehlert/paginate_entries
… ruff check for tests
crankynetman
reviewed
Apr 7, 2025
Collaborator
crankynetman
left a comment
crankynetman
left a comment
There was a problem hiding this comment.
This looks great! I added a few minor inline comments that we can talk about, but I'm happy to default to approving if you disagree with them.
…evious pattern we have created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might also fix the entry list 500? I'm not sure without rolling it out to an instance with a huge amount of data to test with though.