refactor(ruff): ignore ruff on this one

[samoehlert]

ruff seems to think this is a list and doesn't like how we're string indexing

[github-actions]

File	Coverage
All files	81%	✅
config/consumers.py	59%	✅
config/urls.py	69%	✅
config/settings/base.py	70%	✅
config/settings/local.py	73%	✅
scram/route_manager/admin.py	85%	✅
scram/route_manager/models.py	70%	✅
scram/route_manager/views.py	81%	✅
scram/route_manager/api/serializers.py	73%	✅
scram/route_manager/api/views.py	83%	✅
scram/templates/403.html	91%	✅
scram/templates/404.html	91%	✅
scram/templates/base.html	99%	✅

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against ac2fa9e

[grigorescu]

I think this would be better. It still assumes a specific subnet size, which I don't love, but is more flexible.

import ipaddress

first_ip = lambda ip, cidr: str(next(ipaddress.ip_interface(f"{ip}/{cidr}").network.hosts()))

# Take a guess at the gateway IP address. This is a fallback if not otherwise defined.
INTERNAL_IPS += [first_ip(ip, 24) for ip in ips if '.' in ip]
INTERNAL_IPS += [first_ip(ip, 64) for ip in ips if ':' in ip]

[crankynetman]

I think this would be better. It still assumes a specific subnet size, which I don't love, but is more flexible.

import ipaddress

first_ip = lambda ip, cidr: str(next(ipaddress.ip_interface(f"{ip}/{cidr}").network.hosts()))

# Take a guess at the gateway IP address. This is a fallback if not otherwise defined.
INTERNAL_IPS += [first_ip(ip, 24) for ip in ips if '.' in ip]
INTERNAL_IPS += [first_ip(ip, 64) for ip in ips if ':' in ip]

I think that since it's only used in the local settings, I'd just say let's not touch it and tell ruff to noqa the line and when it breaks we can add this message to the stack of "Seriously, Chris??" messages.

[crankynetman]

Works for me!

[crankynetman]

Looks even better. Down with comprehensions!!! 🔱