fix(search): Gracefully handle ValueErrors with search#147
Merged
samoehlert merged 10 commits intomainfrom Apr 14, 2025
Merged
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3d24862 |
…ionality directly we were sort of hacking around this by looking at entry detail for a specific ip instead of searching for it
it turns out they were testing the find_entries feature used in the API for deactivating routes
…ch queries adds the required scaffolding like using the django test client for WUI stuff vs API
…invalid CIDR, but don't show a 400 error page
grigorescu
reviewed
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
We saw a 500 ValueError for two cases: