Skip to content

fix(ux): only show "deactivate entry" button on the entry detail page when the entry is actually active#150

Merged
samoehlert merged 1 commit intomainfrom
topic/soehlert/github-39-deactive-route
Apr 15, 2025
Merged

fix(ux): only show "deactivate entry" button on the entry detail page when the entry is actually active#150
samoehlert merged 1 commit intomainfrom
topic/soehlert/github-39-deactive-route

Conversation

@samoehlert
Copy link
Copy Markdown
Collaborator

@samoehlert samoehlert commented Apr 14, 2025

Screenshot 2025-04-14 at 5 13 55 PM

It just seems like bad user experience to see that.

Closes #39

@github-actions
Copy link
Copy Markdown

File Coverage
All files 84%
config/consumers.py 78%
config/urls.py 69%
config/settings/base.py 70%
config/settings/local.py 73%
scram/route_manager/admin.py 85%
scram/route_manager/models.py 70%
scram/route_manager/views.py 88%
scram/route_manager/api/serializers.py 73%
scram/route_manager/api/views.py 83%
scram/templates/403.html 91%
scram/templates/404.html 91%
scram/templates/base.html 99%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 7b40ded

Copy link
Copy Markdown
Collaborator

@crankynetman crankynetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, this is a nice ux tweak.

@samoehlert samoehlert merged commit 40c27ad into main Apr 15, 2025
21 of 29 checks passed
@samoehlert samoehlert deleted the topic/soehlert/github-39-deactive-route branch April 15, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route detail: Don't show "deactivate route" when it's already inactive

2 participants