Skip to content

fix(login/out): use different settings for login/out redirect url if using the mozilla oidc app#151

Merged
samoehlert merged 3 commits intomainfrom
topic/soehlert/login404
Apr 23, 2025
Merged

fix(login/out): use different settings for login/out redirect url if using the mozilla oidc app#151
samoehlert merged 3 commits intomainfrom
topic/soehlert/login404

Conversation

@samoehlert
Copy link
Copy Markdown
Collaborator

@samoehlert samoehlert commented Apr 23, 2025

The mozilla oidc package has a couple of limitations:
resolve_url
logout redirect url defaults to none

We had this, but took it out on accident when condensing settings.

We actually only had the login_url and logout_url set depending on AUTH_METHOD we actually also needed to set these variables as well.

Closes #152

…using the mozilla oidc app

the mozilla app has some...limitations
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2025

File Coverage
All files 84%
config/consumers.py 78%
config/urls.py 69%
config/settings/base.py 69%
config/settings/local.py 73%
scram/route_manager/admin.py 85%
scram/route_manager/models.py 70%
scram/route_manager/views.py 88%
scram/route_manager/api/serializers.py 73%
scram/route_manager/api/views.py 83%
scram/templates/403.html 91%
scram/templates/404.html 91%
scram/templates/base.html 99%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 3a39415

…depending on the auth method

we incorrectly only set the login_url and logout_url but those only apply when a view has a @login_required decorator. the login_redirect_url and logout_redirect_url are used in other cases including our use case https://docs.djangoproject.com/en/5.2/ref/settings/#std-setting-LOGIN_REDIRECT_URL
@samoehlert samoehlert merged commit 78ee841 into main Apr 23, 2025
20 of 24 checks passed
@samoehlert samoehlert deleted the topic/soehlert/login404 branch April 23, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC logins and logouts 404

2 participants