fix(login/out): use different settings for login/out redirect url if using the mozilla oidc app#151
Merged
samoehlert merged 3 commits intomainfrom Apr 23, 2025
Merged
Conversation
…using the mozilla oidc app the mozilla app has some...limitations
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3a39415 |
…depending on the auth method we incorrectly only set the login_url and logout_url but those only apply when a view has a @login_required decorator. the login_redirect_url and logout_redirect_url are used in other cases including our use case https://docs.djangoproject.com/en/5.2/ref/settings/#std-setting-LOGIN_REDIRECT_URL
grigorescu
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mozilla oidc package has a couple of limitations:
resolve_url
logout redirect url defaults to none
We had this, but took it out on accident when condensing settings.We actually only had the
login_urlandlogout_urlset depending onAUTH_METHODwe actually also needed to set these variables as well.Closes #152