Skip to content

fix(compose): use proper user for postgres healthcheck#159

Merged
crankynetman merged 4 commits intomainfrom
fix/postgres/healthcheck
Sep 17, 2025
Merged

fix(compose): use proper user for postgres healthcheck#159
crankynetman merged 4 commits intomainfrom
fix/postgres/healthcheck

Conversation

@crankynetman
Copy link
Copy Markdown
Collaborator

@crankynetman crankynetman commented Jun 30, 2025

The postgres healthcheck was using the wrong user and failing and oddly enough that wasn't actually causing the healthcheck to fail (probably because of CMD-SHELL?)

This also seems to make test failures a bit more reliable which doesn't make any sense.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 30, 2025

File Coverage
All files 83%
config/consumers.py 78%
config/urls.py 69%
config/settings/base.py 69%
config/settings/local.py 73%
scram/route_manager/admin.py 85%
scram/route_manager/models.py 70%
scram/route_manager/views.py 88%
scram/route_manager/api/serializers.py 73%
scram/route_manager/api/views.py 83%
scram/shared/shared_code.py 56%
scram/templates/403.html 91%
scram/templates/404.html 91%
scram/templates/base.html 99%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 3015763

@crankynetman crankynetman marked this pull request as ready for review July 1, 2025 12:18
samoehlert
samoehlert previously approved these changes Jul 1, 2025
@samoehlert samoehlert dismissed their stale review July 1, 2025 16:41

I realized this may lead to a bug

@samoehlert
Copy link
Copy Markdown
Collaborator

I think this should be in the compose.override.local.yml file maybe? As it stands this would be the same healthcheck in prod where we dont use our test user.

@crankynetman
Copy link
Copy Markdown
Collaborator Author

Good point @samoehlert , fixed.

Copy link
Copy Markdown
Collaborator

@samoehlert samoehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crankynetman crankynetman merged commit da6367c into main Sep 17, 2025
23 of 27 checks passed
@crankynetman crankynetman deleted the fix/postgres/healthcheck branch September 17, 2025 16:45
samoehlert pushed a commit that referenced this pull request Oct 21, 2025
* main:
  ci: remove test that doesn't work on GH Actions (#170)
  fix(typo): use the correct key
  feat(gw_priority): this should allow us to choose which network is the "default gateway" of the macvlan address
  style(isort): fix ruff isort failure
  refactor(update): use the newest mozilla oidc package
  fix(oidc): fix oidc auth. i was overly complex and also misunderstanding the settings
  fix(login/out/redirect): edit the log{in|out}_urls and log{in|out}_redirect_urls to fix the local auth and hopefully the oidc
  fix(compose): use proper user for postgres healthcheck (#159)
  fix: move to bookworm (#166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants