Skip to content

fix(login/logout url): use redirect instead of reverse #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crankynetman wants to merge 3 commits into from
Closed

fix(login/logout url): use redirect instead of reverse #161

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d829bd
fix(login/logout url): use redirect instead of reverse
crankynetman Jul 7, 2025
d870351
fix(login/logout): silly goose, use the right imports.
crankynetman Jul 7, 2025
d15f42a
Merge branch 'main' into fix/login_url_redirect
crankynetman Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scram/route_manager/context_processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Define custom functions that take a request and add to the context before template rendering."""

from django.conf import settings
from django.urls import reverse
from django.shortcuts import redirect

from scram.route_manager.models import Entry

Expand All @@ -12,8 +12,8 @@ def login_logout(request):
Returns:
dict: login and logout URLs
"""
login_url = reverse(settings.LOGIN_URL)
logout_url = reverse(settings.LOGOUT_URL)
login_url = redirect(settings.LOGIN_URL)
logout_url = redirect(settings.LOGOUT_URL)
return {"login": login_url, "logout": logout_url}


Expand Down
Loading