feat(gw_priority): this should allow us to choose which network is th…#169
Merged
samoehlert merged 2 commits intomainfrom Oct 14, 2025
Merged
feat(gw_priority): this should allow us to choose which network is th…#169samoehlert merged 2 commits intomainfrom
samoehlert merged 2 commits intomainfrom
Conversation
…e "default gateway" of the macvlan address previously on dual connected gobgp instances, it would often respond over the docker compose network, never being able to reach its destination
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 785f082 |
crankynetman
previously approved these changes
Oct 10, 2025
Collaborator
crankynetman
left a comment
crankynetman
left a comment
There was a problem hiding this comment.
This looks great to me!
crankynetman
approved these changes
Oct 14, 2025
Collaborator
crankynetman
left a comment
crankynetman
left a comment
There was a problem hiding this comment.
lgtm and this time i mean it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e "default gateway" of the macvlan address
previously on dual connected gobgp instances, it would often respond over the docker compose network, never being able to reach its destination