Unified memory#157
Merged
simonpintarelli merged 16 commits intomasterfrom Feb 4, 2026
Merged
Conversation
mtaillefumier
force-pushed
the
unified_memory
branch
from
c048224 to
ded1f88
Compare
…SMA_GPU_UNIFIED_MEMORY. It is off by default
Member
|
cscs-ci run gh200 |
Collaborator
Author
|
I need to push a patch for fixing a typo |
simonpintarelli
approved these changes
Feb 4, 2026
| #else | ||
| } | ||
| #endif | ||
| } |
Member
There was a problem hiding this comment.
I think the last closing } shouldn't be there.
| // requires memory_pool_.resize(cpu_mem_limit); | ||
| #ifdef COSMA_HAVE_GPU | ||
| gpu_ctx_ = gpu::make_context<Scalar>(streams, tile_m, tile_n, tile_k); | ||
| gpu_ctx_.use_unified_memory_ = cosma::get_unified_memory(); |
Member
There was a problem hiding this comment.
gpu_ctx_ is a pointer to gpu::mm_handle<..>, which is a class from tiled-mm.
But there is no corresponding PR to tiled-mm introducing a field use_unified_memory_.
Also probably needs an #ifdef COSMA_USE_UNIFIED_MEMORY here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AMD unified memory support to COSMA