Conversation
Merged
evaleev
approved these changes
Feb 1, 2026
Owner
|
Look good to me. Could not spot the issue in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've checked and your
prepare-2-13-0branch works as-is against Psi4. This includes Erica's mp2-f12 code, so the G12 is working (Psi4 doesn't build the G12DKH). Only two lines of this PR are mildly important (1 and 4 below).check_required_components(${L2})line so thatfind_package(... COMPONENTS ...)can reject installations.g12_ssss_d0;g12_ssss_d1for AM=4. Brief examination of themacro(process_integrals_class_altfunction, and I'm not seeing the problem. It doesn't bother me, and I added a line to the INSTALL.md that codes for this ints class are incomplete.