Update to Work with Eigen 5.0.0#395
Merged
evaleev merged 4 commits intoevaleev:masterfrom Feb 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s CMake Eigen finder to correctly detect the Eigen version after Eigen 5.0.0 moved its version header.
Changes:
- Update
FindEigen3.cmaketo read version macros fromEigen/Versionfor Eigen 5.x. - Retain fallback logic to read version macros from
Eigen/src/Core/util/Macros.hfor Eigen 3.x.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Same thing will need to be modified in TiledArray as well, FindEigen3.cmake. |
Owner
Yes, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eigen 5.0.0 changes where version is located. Needs to find version header for Eigen 5.x.x and Eigen 3.x.x.
Details