[cmake] boost check supports in-tree targets#397
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances CMake configuration to support Boost when built as part of the source tree, rather than assuming it's always an imported target. The changes address both monolithic and modularized Boost variants, and include a small bug fix in the Eigen3 variable check.
Changes:
- Added logic to detect and handle non-imported Boost targets by extracting include directories from generator expressions
- Fixed incorrect variable reference syntax for
LIBINT_HAS_EIGENcheck - Extended Eigen3 version detection to support Eigen 5.x header locations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| export/CMakeLists.txt.export | Removed erroneous ${} syntax around LIBINT_HAS_EIGEN variable check |
| cmake/modules/int_checkboost.cmake | Added support for non-imported Boost targets by extracting include directories from BUILD_INTERFACE generator expressions |
| cmake/modules/FindEigen3.cmake | Added fallback logic to detect Eigen version headers in both 5.x and 3.x locations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently
int_checkboostassumedIMPORTEDBoost::headers, but this may not be true if Boost is built as part of the source tree. This adds support for non-IMPORTEDBoost::headers, and the modularized variant which must useBoost::preprocessor