Skip to content

[cmake] boost check supports in-tree targets#397

Merged
evaleev merged 7 commits intomasterfrom
cmake/boost-check-supports-intree-targets
Feb 2, 2026
Merged

[cmake] boost check supports in-tree targets#397
evaleev merged 7 commits intomasterfrom
cmake/boost-check-supports-intree-targets

Conversation

@evaleev
Copy link
Owner

@evaleev evaleev commented Feb 2, 2026

currently int_checkboost assumed IMPORTED Boost::headers, but this may not be true if Boost is built as part of the source tree. This adds support for non-IMPORTED Boost::headers, and the modularized variant which must use Boost::preprocessor

@evaleev evaleev requested a review from Copilot February 2, 2026 21:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances CMake configuration to support Boost when built as part of the source tree, rather than assuming it's always an imported target. The changes address both monolithic and modularized Boost variants, and include a small bug fix in the Eigen3 variable check.

Changes:

  • Added logic to detect and handle non-imported Boost targets by extracting include directories from generator expressions
  • Fixed incorrect variable reference syntax for LIBINT_HAS_EIGEN check
  • Extended Eigen3 version detection to support Eigen 5.x header locations

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
export/CMakeLists.txt.export Removed erroneous ${} syntax around LIBINT_HAS_EIGEN variable check
cmake/modules/int_checkboost.cmake Added support for non-imported Boost targets by extracting include directories from BUILD_INTERFACE generator expressions
cmake/modules/FindEigen3.cmake Added fallback logic to detect Eigen version headers in both 5.x and 3.x locations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

evaleev and others added 2 commits February 2, 2026 16:47
typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@evaleev evaleev merged commit e421248 into master Feb 2, 2026
10 checks passed
@evaleev evaleev deleted the cmake/boost-check-supports-intree-targets branch February 2, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants