Silence compiler warnings in molden.h and build_libint.cc#420
Open
evaleev wants to merge 1 commit into
Open
Conversation
- molden.h: use libint2::nbf and pass solid_harmonics_ordering() to INT_SOLIDHARMINDEX to match the current API and avoid deprecation warnings - build_libint.cc: mark build_R12kG12_2b_2k_separate as [[maybe_unused]] since it is only used under specific configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
molden.h: uselibint2::nbfinstead of the deprecatedBasisSet::nbf, and passlibint2::solid_harmonics_ordering()toINT_SOLIDHARMINDEXto match the current API.build_libint.cc: markbuild_R12kG12_2b_2k_separate[[maybe_unused]]since it is only referenced under specific configurations.Test plan