Fix Ruby 4.0 warning: use require_relative for internal files#148
Open
paddor wants to merge 2 commits intoevanphx:masterfrom
Open
Fix Ruby 4.0 warning: use require_relative for internal files#148paddor wants to merge 2 commits intoevanphx:masterfrom
paddor wants to merge 2 commits intoevanphx:masterfrom
Conversation
Ruby 4.0 removed `benchmark` from default gems. When benchmark-ips uses `require 'benchmark/timing'`, Ruby's gem activation system sees the `benchmark/` prefix and warns that the `benchmark` gem is not a default gem, even though all these files belong to benchmark-ips. Using `require_relative` bypasses gem activation entirely, resolving the warning: benchmark/timing is found in benchmark, which is not part of the default gems since Ruby 4.0.0.
Contributor
|
Which warnings? |
Contributor
That seems a clear bug of https://github.com/ruby/ruby/blob/master/lib/bundled_gems.rb. |
eregon
reviewed
Mar 11, 2026
Author
|
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all
requirecalls for internal files withrequire_relativeinlib/benchmark/ips.rband the test suite to fix warnings on Ruby 4.0.