-
-
Notifications
You must be signed in to change notification settings - Fork 40
Declarative database schema together with migrator unification v1 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents They're yet dummy, but more will come then
We'll need to find a marter way for migration, probably hash calculated automatically as it's handled eventually or some id.
… factory We'll use composition instead
…use their names isntead of urns Thanks to that we'll be able to easier define the schema in the pongo like way. Made also migrations unique by adding schema component key to them.
…ns and schema components
…ccidental overrides
…ke column type etc.
50ff2a3 to
77e30dd
Compare
649f945 to
ec7db8e
Compare
afcbc6a to
3e35bff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not fully completed, but it already added unified dumbo schema management and simplified SQLToken structure to be able to reuse it in schema components.
That's the first step for declarative database management and reusing it in Pongo and Emmett a centralised way to manage migrations.
Added also the type-driven validation to enable type-safe schema definition.
This will need to do a follow-up to actually apply it in Pongo and finish validation, but it's already Duke Nukem Forever, so let's keep it at least merged and then try to do baby steps.