Open
Conversation
Co-authored-by: adriano <adriano@exa.ai>
devin-ai-integration bot
added a commit
that referenced
this pull request
Dec 12, 2025
…nv vars This fixes bug #1 where overriding nproc_per_node via with_overrides would not change the number of processes for single-node elastic tasks. For single-node elastic tasks (task_type='python-task'), the _execute method reads PET_NPROC_PER_NODE, PET_NNODES, PET_MAX_RESTARTS, and PET_MONITOR_INTERVAL from environment variables. However, these env vars were never being set in the task template during serialization. The fix adds an environment property override to PytorchElasticFunctionTask that includes the elastic config as environment variables. This ensures that when task_config is modified via with_overrides, the elastic configuration is correctly passed to the pod via environment variables. Combined with the previous fix (dynamic task_type property), this now fully supports: - Bug #1: single-node (1 proc) -> single-node (multiple procs) override - Bug #2: single-node (1 proc) -> multi-node (multiple procs) override Co-Authored-By: carlos@exa.ai <carlosmarques.personal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains changes generated by Cursor background composer.