kfpytorch: make Elastic task_type dynamic so nnodes overrides flip single-pod vs distributed#9
Draft
codegen-sh[bot] wants to merge 3 commits intomasterfrom
Conversation
…ngle-pod (python-task) vs distributed (pytorch)\n\n- Override task_type property in PytorchElasticFunctionTask to derive from current task_config.nnodes\n- Support int and range strings (e.g., 1:1) without torch import\n- Keeps task_type_version unchanged and preserves existing get_custom branching\n\nCo-authored-by: Adriano <adriano@exa.ai>
…vous misconfig from env overrides\n\n- When task_type resolves to python-task, ignore PET_NNODES and pass 1 to parse_min_max_nnodes\n- Prevents elastic launcher waiting for >1 nodes in single-pod runs\n\nCo-authored-by: Adriano <adriano@exa.ai>
…-pod mode\n\n- Log mode, nnodes_str (raw), parsed min/max, nproc_per_node, rdzv_backend, rdzv_endpoint, start_method\n- Derive single_pod_mode from dynamic task_type\n- Use 127.0.0.1:0 for rendezvous in single-pod to avoid DNS/IPv6 localhost edge cases\n\nCo-authored-by: Adriano <adriano@exa.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Why
Testing
Notes
💻 View my work • About Codegen