Open
Conversation
needed for part of pubsub wrapper
cleans up the global scope, and also makes things a little less wonky IMO
Since the prototype method was used, I had to transfer all the prototype methods over as well. This was a little funky and quite honestly... I don't like it But it works
Member
Author
|
Testing needed on Firefox:
Confirmed working on Chrome Testing:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds worker into the form object instead of into an array in the global scope
goal here is to keep the global scope completely clean if at all possible, exposing debug methods elsewhere