Draft
Conversation
also simplifies the parameters for the updatePercent and appendVerification function for now the old event emitter functions are commented out
its extraneous so its not necessary anyways
All that's left is to test each of the pages
TODO: create a new debug solution
debug logger uses WeakMap to track forms and the history of the logged messages if the debug attribute is not on the form, it is not added to the WeakMap A proxy is used so that whenever a message is added to a specific log type: log, info, error, warn it will be saved as such too It might be nice to add a callback argument, but if that happens, it is time to break it out into its own package
adds new logger util to manage debugging and events no more pubsub for handling inner function communications instead just going to use regular old function to function style programming call me old fasioned You can search for `log.` to see how it is used. It is also a likely candidate for a separate package in its own right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes PubSub wrapper to clean the slate and try out different design patterns.
After living with the PubSub in the beta, it didn't make sense for this small of a package, so I scrapped it in favor of making a utility logging proxy.
This will fill the gap, still allow for debugging with events on a form by form basis.
I think the logging proxy may likely be a candidate for its own package, but that may need further assessment.