Skip to content

Fix for DifferenceOfSquaresTest.bat#77

Open
nastamattina wants to merge 1 commit intoexercism:mainfrom
nastamattina:patch-1
Open

Fix for DifferenceOfSquaresTest.bat#77
nastamattina wants to merge 1 commit intoexercism:mainfrom
nastamattina:patch-1

Conversation

@nastamattina
Copy link
Copy Markdown

For issue reported on https://forum.exercism.org/t/difference-of-squares-test-script-keep-on-showing-failed/20000 Seems like the filePath is never set in the test bat when the runner is false. Simple fix, just add set “filePath=%slug%.bat” to line 55, i.e., in :Assert, tested and working

For issue reported on https://forum.exercism.org/t/difference-of-squares-test-script-keep-on-showing-failed/20000 
Seems like the filePath is never set in the test bat when the runner is false. Simple fix, just add set “filePath=%slug%.bat” to line 56, i.e., in :Assert, tested and working
@github-actions
Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions
Copy link
Copy Markdown

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant