Add piecing it together practice exercise#2961
Conversation
kahgoh
left a comment
There was a problem hiding this comment.
Thanks! This is a great start!
In the
config.jsonfile, I includedexceptions,for-loops, andif-else-statementsas prerequisites. I wasn’t sure whether to add them to thepracticesarray as well, since most exercises seem to leave it empty.
Leaving the practices array empty is fine!
The only thing missing is the gradle directory. You should simply be able to copy the contents from another exercise, like change (this is needed for students to run ./gradlew properly).
exercises/practice/piecing-it-together/.meta/src/reference/java/PartialJigsawInformation.java
Outdated
Show resolved
Hide resolved
exercises/practice/piecing-it-together/.meta/src/reference/java/PartialJigsawInformation.java
Outdated
Show resolved
Hide resolved
exercises/practice/piecing-it-together/.meta/src/reference/java/PartialJigsawInformation.java
Outdated
Show resolved
Hide resolved
exercises/practice/piecing-it-together/src/test/java/PiecingItTogetherTest.java
Outdated
Show resolved
Hide resolved
exercises/practice/piecing-it-together/src/main/java/PiecingItTogether.java
Outdated
Show resolved
Hide resolved
exercises/practice/piecing-it-together/.meta/src/reference/java/PartialJigsawInformation.java
Outdated
Show resolved
Hide resolved
exercises/practice/piecing-it-together/.meta/src/reference/java/PartialJigsawInformation.java
Outdated
Show resolved
Hide resolved
…and type improvements
…d and constant in piecing-it-together test file
|
Hello, thank you for your detailed comments! I’ve made the requested changes. I just have one question: I currently placed the |
kahgoh
left a comment
There was a problem hiding this comment.
I currently placed the
JigsawInfoclass (previouslyPartialJigsawInformation) in both.meta/src/reference/javaandsrc/main/java. Is that okay, or was it only needed in the reference folder?
Yes, that's fine! In fact, that's currently needed for the CI tests to pass.
exercises/practice/piecing-it-together/src/main/java/JigsawInfo.java
Outdated
Show resolved
Hide resolved
exercises/practice/piecing-it-together/src/main/java/JigsawInfo.java
Outdated
Show resolved
Hide resolved
exercises/practice/piecing-it-together/src/main/java/JigsawInfo.java
Outdated
Show resolved
Hide resolved
|
Hi, I’ve updated the builder in the |
exercises/practice/piecing-it-together/.meta/src/reference/java/PiecingItTogether.java
Outdated
Show resolved
Hide resolved
…piecing-it-together
pull request
Add Piecing It Together practice exercise based on the instructions detailed here.
In the
config.jsonfile, I includedexceptions,for-loops, andif-else-statementsas prerequisites. I wasn’t sure whether to add them to thepracticesarray as well, since most exercises seem to leave it empty.I’ve read the contribution guidelines, but please let me know if I’ve missed anything.
Closes #2949
Reviewer Resources:
Track Policies