Skip to content

Zig version update#41

Merged
nilslice merged 4 commits into
mainfrom
zig-version-update
May 14, 2025
Merged

Zig version update#41
nilslice merged 4 commits into
mainfrom
zig-version-update

Conversation

@usdogu
Copy link
Copy Markdown
Collaborator

@usdogu usdogu commented Apr 1, 2025

No description provided.

usdogu added 2 commits April 1, 2025 20:38
breaking: Changes module name to extism_pdk
breaking: HTTP internal headers function renamed to getInternal to avoid conflicts
@usdogu usdogu requested a review from nilslice as a code owner April 1, 2025 17:44
@jedisct1
Copy link
Copy Markdown

Please merge this. The Zig PDK cannot. be used with current versions of ZIg :(

@nilslice
Copy link
Copy Markdown
Member

Unsure why the macOS CI is failing..

@usdogu
Copy link
Copy Markdown
Collaborator Author

usdogu commented May 14, 2025

I think it has something to do with the latest cli archive for arm64 macOS, tar only complains about it in macos-latest

@nilslice
Copy link
Copy Markdown
Member

Ok, I'll merge so @jedisct1 isn't blocked -- and we can investigate in a follow up :)

@nilslice nilslice merged commit a8d4e04 into main May 14, 2025
0 of 2 checks passed
@nilslice nilslice deleted the zig-version-update branch May 14, 2025 17:29
@nilslice
Copy link
Copy Markdown
Member

@jedisct1, for now, can you just point at the git ref in your zig deps? I'll make a release once we have the macos tests sorted

@zshipko
Copy link
Copy Markdown

zshipko commented May 14, 2025

i ran all the checks locally and they seem to work, i wonder if it's related to the https://jsonplaceholder.typicode.com request? i've had some issue with that on github ci in the past but not sure why that would be a macos-only thing...

@jedisct1
Copy link
Copy Markdown

Yes, that seems to work! Thank you so much!

evacchi added a commit to dylibso/xtp-zig-bindgen that referenced this pull request May 15, 2025
align to the changes in extism/zig-pdk#41

Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi
Copy link
Copy Markdown

evacchi commented May 15, 2025

it looks like the macOS failure was a transient CI issue that caused extism executable to be an empty file

In fact, the job is now green https://github.com/extism/zig-pdk/actions/runs/15027199809/job/42293894587

I'll open a PR to add more verbose logging in case of failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants