Skip to content

fix(macro): reference mutability inside Option #515 #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kakserpom wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(macro): reference mutability inside Option #515 #615

kakserpom wants to merge 2 commits into from
+49 −3

Conversation

@kakserpom
Copy link
Contributor

@kakserpom kakserpom commented Dec 18, 2025

Fixes #515

@coveralls
Copy link

coveralls commented Dec 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20413986967

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 36.097%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/macros/src/function.rs 0 1 0.0%
src/types/array/mod.rs 0 2 0.0%
Totals Coverage Status
Change from base Build 20412913109: -0.02%
Covered Lines: 1676
Relevant Lines: 4643
💛 - Coveralls

@ptondereau
Copy link
Member

ptondereau commented Dec 18, 2025

bugfix(macro): reference mutability inside Option
fix(macro): reference mutability inside Option

ptondereau
ptondereau previously approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@kakserpom kakserpom changed the title bugfix(macro): reference mutability inside Option #515 fix(macro): reference mutability inside Option #515 Dec 18, 2025
@kakserpom kakserpom force-pushed the 515_ref_mutability branch 2 times, most recently from 5f20453 to fa5bdcd Compare December 21, 2025 15:42
ptondereau
ptondereau reviewed Dec 21, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptondereau ptondereau ptondereau left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Argument #1 ($foo) could not be passed by reference

3 participants

@kakserpom @coveralls @ptondereau