Skip to content

fix(zval): Heap corruption with persistent=true #424 #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ptondereau merged 1 commit into from
Dec 21, 2025
Merged

fix(zval): Heap corruption with persistent=true #424 #622

ptondereau merged 1 commit into from
Dec 21, 2025
+135 −6

Conversation

@kakserpom
Copy link
Contributor

@kakserpom kakserpom commented Dec 20, 2025

Fixes #424

@kakserpom kakserpom marked this pull request as draft December 20, 2025 07:49
@kakserpom kakserpom force-pushed the 424_zval_heap_corruption branch from 0cf2682 to 07491d1 Compare December 20, 2025 07:53
@coveralls
Copy link

coveralls commented Dec 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20410531123

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 36.049%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/zval.rs 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
src/types/zval.rs 1 36.71%
Totals Coverage Status
Change from base Build 20410324711: 0.03%
Covered Lines: 1655
Relevant Lines: 4591
💛 - Coveralls

@kakserpom kakserpom force-pushed the 424_zval_heap_corruption branch from 07491d1 to 8255f1d Compare December 20, 2025 07:58
@kakserpom kakserpom marked this pull request as ready for review December 20, 2025 07:58
@kakserpom kakserpom force-pushed the 424_zval_heap_corruption branch 2 times, most recently from c31b0f7 to e52dcfb Compare December 21, 2025 06:24
ptondereau
ptondereau requested changes Dec 21, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments erasure to be done but LGTM + do a rebase please

@kakserpom kakserpom force-pushed the 424_zval_heap_corruption branch 2 times, most recently from e52dcfb to 6751e99 Compare December 21, 2025 13:27
@kakserpom kakserpom force-pushed the 424_zval_heap_corruption branch from 6751e99 to 09947d3 Compare December 21, 2025 13:28
@kakserpom
Copy link
Contributor Author

kakserpom commented Dec 21, 2025

@ptondereau Done

ptondereau
ptondereau approved these changes Dec 21, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnak you!

@ptondereau ptondereau merged commit b4d16f7 into extphprs:master Dec 21, 2025
62 of 63 checks passed
@Xenira Xenira mentioned this pull request Dec 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptondereau ptondereau ptondereau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Core dumped where try Zval::set_string with persist trye

3 participants

@kakserpom @coveralls @ptondereau