Skip to content

feat(class): Static properties and methods #252 #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ptondereau merged 2 commits into from
Dec 21, 2025
Merged

feat(class): Static properties and methods #252 #627

ptondereau merged 2 commits into from
Dec 21, 2025
+511 −35

Conversation

@kakserpom
Copy link
Contributor

@kakserpom kakserpom commented Dec 20, 2025

Implements #252

@coveralls
Copy link

coveralls commented Dec 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20411951551

Details

  • 8 of 51 (15.69%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 35.779%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/class.rs 0 2 0.0%
src/builders/class.rs 2 6 33.33%
src/builders/module.rs 0 6 0.0%
crates/macros/src/class.rs 4 19 21.05%
src/zend/class.rs 0 16 0.0%
Totals Coverage Status
Change from base Build 20411090076: -0.3%
Covered Lines: 1658
Relevant Lines: 4634
💛 - Coveralls

@kakserpom kakserpom force-pushed the 252_static_props_and_methods branch 8 times, most recently from 7eb2658 to b39a772 Compare December 21, 2025 13:38
ptondereau
ptondereau previously approved these changes Dec 21, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some questions

@kakserpom kakserpom force-pushed the 252_static_props_and_methods branch 3 times, most recently from a3be429 to 2c2b7ba Compare December 21, 2025 15:18
@kakserpom kakserpom force-pushed the 252_static_props_and_methods branch from 2c2b7ba to b8c720d Compare December 21, 2025 15:28
ptondereau
ptondereau approved these changes Dec 21, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ptondereau ptondereau merged commit b511af6 into extphprs:master Dec 21, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptondereau ptondereau ptondereau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kakserpom @coveralls @ptondereau