python version problem, package problem#3
python version problem, package problem#3martinschatz-cz wants to merge 19 commits intofabrylab:masterfrom
Conversation
rgerum
left a comment
rgerum
left a comment
There was a problem hiding this comment.
This looks like a good pull requests with tests. I added some comments.
@AndreasBauerGit what do you think?
README.md
Outdated
|
|
||
| If you want to use jupyterlab with black packge | ||
| ``` | ||
| conda install jupyterlab jupyterlab_code_formatter black isort -c conda-forge |
There was a problem hiding this comment.
This reference to jupyterlab and black seems a bit out of place as we are nowhere else referencing to jupyterlab. So I guess if the user knows about jupyterlab and wants to use it they know how to install it.
README.md
Outdated
| Please refer to the [Documentation](https://pytfm.readthedocs.io/en/latest/) of pyTFM for detailed instructions on installation and usage. | ||
|
|
||
| ## Conda enviroment creation | ||
| You need to create python 3.7 enviroment. |
There was a problem hiding this comment.
Is there a reason why to focus on python 3.7? Are newer python versions not supported.
|
@martinschatz-cz Thanks a lot for this feedback! I will check out the pip package asap. Also your unit test are definitely a great idea. I will probably even add some more. I will take a deeper look into everything by the end of next week! |
|
Hi, |
|
Hey @AndreasBauerGit GitHub is reminding me that I still have this PR open. Would it be still useful? |
3 participants
Hi @AndreasBauerGit,
I like your package, and we would like to test it a bit in our core facility. However, I was missing some info on how to actually make your package work (python version, simple tests, and so on). So I am adding my bit of information. In the end, I am using jupyter-lab, and everything works.
Also, you might want to know that your pip package is broken (probably because of scikit-image version), and correct_stage_drift function is not working unless you install the package from git.
Great work, guys! I love what you have done. The documentation and examples helped me a lot. I hope I will be able to add my bit to ease of use :)
Cheers,
Martin