Handle edge cases that the experiment only have one parameter in SensitivityPlots#4931
Open
andycylmeta wants to merge 1 commit intofacebook:mainfrom
Open
Handle edge cases that the experiment only have one parameter in SensitivityPlots#4931andycylmeta wants to merge 1 commit intofacebook:mainfrom
andycylmeta wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@andycylmeta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94100579. |
andycylmeta
added a commit
to andycylmeta/Ax
that referenced
this pull request
Feb 23, 2026
…itivityPlots (facebook#4931) Summary: InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment Reviewed By: mpolson64, eonofrey Differential Revision: D94100579
14cf854 to
cb5eeb1
Compare
andycylmeta
added a commit
to andycylmeta/Ax
that referenced
this pull request
Feb 23, 2026
…itivityPlots (facebook#4931) Summary: Pull Request resolved: facebook#4931 InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment Reviewed By: mpolson64, eonofrey Differential Revision: D94100579
cb5eeb1 to
61754c9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4931 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 595 595
Lines 63189 63206 +17
=======================================
+ Hits 61170 61187 +17
Misses 2019 2019 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andycylmeta
added a commit
to andycylmeta/Ax
that referenced
this pull request
Feb 24, 2026
…itivityPlots (facebook#4931) Summary: InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment Reviewed By: mpolson64, eonofrey Differential Revision: D94100579
61754c9 to
9106a29
Compare
andycylmeta
added a commit
to andycylmeta/Ax
that referenced
this pull request
Feb 24, 2026
…itivityPlots (facebook#4931) Summary: InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment Reviewed By: mpolson64, eonofrey Differential Revision: D94100579
9106a29 to
fc1ed22
Compare
andycylmeta
added a commit
to andycylmeta/Ax
that referenced
this pull request
Feb 24, 2026
…itivityPlots (facebook#4931) Summary: Pull Request resolved: facebook#4931 InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment Reviewed By: mpolson64, eonofrey Differential Revision: D94100579
fc1ed22 to
5d4cd16
Compare
…itivityPlots (facebook#4931) Summary: Pull Request resolved: facebook#4931 InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment Reviewed By: mpolson64, eonofrey Differential Revision: D94100579
5d4cd16 to
2e98ecc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: InsightAnalyses defaults to use
second orderwhen running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to usefirst orderwhen there's only one parameter in the experimentReviewed By: eonofrey
Differential Revision: D94100579