Skip to content

Comments

Handle edge cases that the experiment only have one parameter in SensitivityPlots#4931

Open
andycylmeta wants to merge 1 commit intofacebook:mainfrom
andycylmeta:export-D94100579
Open

Handle edge cases that the experiment only have one parameter in SensitivityPlots#4931
andycylmeta wants to merge 1 commit intofacebook:mainfrom
andycylmeta:export-D94100579

Conversation

@andycylmeta
Copy link
Contributor

Summary: InsightAnalyses defaults to use second order when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use first order when there's only one parameter in the experiment

Reviewed By: eonofrey

Differential Revision: D94100579

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 23, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 23, 2026

@andycylmeta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94100579.

andycylmeta added a commit to andycylmeta/Ax that referenced this pull request Feb 23, 2026
…itivityPlots (facebook#4931)

Summary:

InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment

Reviewed By: mpolson64, eonofrey

Differential Revision: D94100579
andycylmeta added a commit to andycylmeta/Ax that referenced this pull request Feb 23, 2026
…itivityPlots (facebook#4931)

Summary:
Pull Request resolved: facebook#4931

InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment

Reviewed By: mpolson64, eonofrey

Differential Revision: D94100579
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.80%. Comparing base (a34f523) to head (2e98ecc).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4931   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files         595      595           
  Lines       63189    63206   +17     
=======================================
+ Hits        61170    61187   +17     
  Misses       2019     2019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

andycylmeta added a commit to andycylmeta/Ax that referenced this pull request Feb 24, 2026
…itivityPlots (facebook#4931)

Summary:

InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment

Reviewed By: mpolson64, eonofrey

Differential Revision: D94100579
andycylmeta added a commit to andycylmeta/Ax that referenced this pull request Feb 24, 2026
…itivityPlots (facebook#4931)

Summary:

InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment

Reviewed By: mpolson64, eonofrey

Differential Revision: D94100579
andycylmeta added a commit to andycylmeta/Ax that referenced this pull request Feb 24, 2026
…itivityPlots (facebook#4931)

Summary:
Pull Request resolved: facebook#4931

InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment

Reviewed By: mpolson64, eonofrey

Differential Revision: D94100579
…itivityPlots (facebook#4931)

Summary:
Pull Request resolved: facebook#4931

InsightAnalyses defaults to use `second order` when running SensitivityAnalysisPlot. In the edge cases that the experiment only have one parameter, it errors out because the pair-wise effect analyses can't be computed. This diff adds a fallback to use `first order` when there's only one parameter in the experiment

Reviewed By: mpolson64, eonofrey

Differential Revision: D94100579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants