[Cisco][G200 & G202x] Fix for PFC test cases#928
Open
itskittycisco wants to merge 1 commit intofacebook:mainfrom
Open
[Cisco][G200 & G202x] Fix for PFC test cases#928itskittycisco wants to merge 1 commit intofacebook:mainfrom
itskittycisco wants to merge 1 commit intofacebook:mainfrom
Conversation
itskittycisco
force-pushed
the
pfc_multitest_fixes
branch
from
fb1eebe to
a38b22b
Compare
itskittycisco
changed the title
itskittycisco
force-pushed
the
pfc_multitest_fixes
branch
from
a38b22b to
18de125
Compare
itskittycisco
requested review from
ashutoshgrewal,
daiwei1983,
jasmeetbagga,
msomasundaran,
phshaikh,
shri-khare and
zechengh09
as code owners
itskittycisco
changed the title
itskittycisco
changed the title
itskittycisco
force-pushed
the
pfc_multitest_fixes
branch
from
18de125 to
4a9cd61
Compare
Contributor
|
This can be closed. Similar fix is delivered to fboss code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.............................................................Passed
black................................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
Summary
Test Plan
Manual test run:
AgentTrafficPfcZeroPgHeadroomTest.verifyPfcWithZeroPgHeadRoomCfg. -> PASS
AgentTrafficPfcTest.verifyPfcWithDefaultCfg. - PASS
AgentTrafficPfcTest.verifyIngressPriorityGroupWatermarks. - PASS
AgentTrafficPfcTest.verifyPfcWithZeroGlobalHeadRoomCfg - PASS
AgentTrafficPfcTest.verifyBufferPoolWatermarks - PASS
AgentTrafficPfcTest.verifyPfcWithMapChanges_0. - PASS
AgentTrafficPfcTest.verifyPfcWithMapChanges_1. - PASS
HwVerifyPfcConfigInHwTest.PfcRxEnabledTxEnabled - PASS
HwVerifyPfcConfigInHwTest.PfcWatchdogProgrammingSequence - PASS