Fix typo in ThriftLibrary.cmake#673
Closed
mdaniels5757 wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
Was introduced in 5803839
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 13, 2026
Summary: At least I'm pretty sure it's a typo, vitaut? It was introduced in 58038399cefc0c2256ce4ef5444dee37147cbf07. X-link: facebook/fbthrift#673 Reviewed By: vitaut Differential Revision: D96488136 Pulled By: iahs fbshipit-source-id: c44097fe61f081106e7e409bb49618b0d3c24736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least I'm pretty sure it's a typo, @vitaut? It was introduced in 5803839.