Skip to content

dev-middleware: Update chromium-edge-launcher to ^0.3.0#51340

Closed
qwertychouskie wants to merge 1 commit into
facebook:mainfrom
qwertychouskie:patch-1
Closed

dev-middleware: Update chromium-edge-launcher to ^0.3.0#51340
qwertychouskie wants to merge 1 commit into
facebook:mainfrom
qwertychouskie:patch-1

Conversation

@qwertychouskie
Copy link
Copy Markdown

Summary:

Update chromium-edge-launcher to ^0.3.0, which has been updated to no longer use some deprecated packages/versions.

Changelog:

Changelog: https://github.com/cezaraugusto/chromium-edge-launcher/releases

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @qwertychouskie!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@react-native-bot
Copy link
Copy Markdown
Collaborator

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against c1c82da

@veksen
Copy link
Copy Markdown

veksen commented Sep 30, 2025

What's stopping this from going in?

@Lionhunt3r
Copy link
Copy Markdown

Is there a timeline for when it is going to be solved?

@gameroman
Copy link
Copy Markdown

There is a new version of chromium-edge-launcher now (2.0.1)

@stianjensen
Copy link
Copy Markdown
Contributor

Upgrading to 0.3.0 seems like a good no-regret idea!

Upgrading further, to 2.x would also be good, to get both rimraf and mkdirp out of the dependency tree. The package is ESM-only at that version, but given the current Node version constraints of react-native that should not pose a problem, as require(ESM) is available in those Node versions.

@stianjensen
Copy link
Copy Markdown
Contributor

This PR is now a duplicate of #54711, which is merged.

A new PR can be opened to look into modernizing further.

@qwertychouskie qwertychouskie deleted the patch-1 branch May 6, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants