Replace glob@^7.0.0 with tinyglobby@^0.2.15#54737
Closed
kitten wants to merge 7 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
kitten
force-pushed
the
@kitten/security/replace-glob-with-tinyglobby
branch
from
2c69744 to
8fa4f28
Compare
kitten
force-pushed
the
@kitten/security/replace-glob-with-tinyglobby
branch
from
20409c4 to
574cda0
Compare
A difference between `glob` and `tinyglob` is how `ignore` is applied. `glob` has an exception that only applies `.../*` patterns to files. `tinyglobby` doesn't make this distinction and hence that'd also exclude directories to be traversed. Patterns have been adjusted to account for this.
This was referenced Dec 2, 2025
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Dec 3, 2025
Summary: Follows facebook/react-native#54737. Replaces #1442. Replace `glob@^7.0.0` with the lighter weight `tinyglobby` package to resolve deprecation warnings. This affects only Metro's scripts files. Changelog: - **[Security]**: Replace `glob@^7.0.0` with `tinyglobby@^0.2.15` Reviewed By: vzaidman Differential Revision: D88146420
meta-codesync Bot
pushed a commit
to facebook/metro
that referenced
this pull request
Dec 3, 2025
Summary: Pull Request resolved: #1627 Follows facebook/react-native#54737. Replaces #1442. Replace `glob@^7.0.0` with the lighter weight `tinyglobby` package to resolve deprecation warnings. This affects only Metro's scripts files. Changelog: - **[Security]**: Replace `glob@^7.0.0` with `tinyglobby@^0.2.15` Reviewed By: vzaidman Differential Revision: D88146420 fbshipit-source-id: f201240589951be236f3c941258551d58340d5d8
Collaborator
|
This pull request was successfully merged by @kitten in 41eace0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This replaces
glob@^7.0.0withtinyglobby@^0.2.15.glob@7has been deprecated for a while and some versions after had security notices released for them. The plan is to backport this PR to0.81.xand onwards.Note
This is a stopgap solution until
fs.globbecomes generally available with the EOL of Node v20Succeeds:
glob@^13.0.0and adjust usage #54669glob@7toglob@10to resolve deprecation warnings #48875Notable differences
tinyglobbyisn't a 1:1 replacement forglob. They have a few breaking changes planned for v1 that will reduce the amount of differences, but they haven't landed these yet. A small summary of the differences are:expandDirectories: falseneeds to be set to avoidtinyglobbyexpanding directories recursively when they exactly match a glob and to avoid**being misinterpretedonlyFiles: falseneeds to be set if we want to match directoriesignorealso stops traversal, meaning, patterns matching directories (e.g..../*) will be interpreted like a.../**/*ignore pattern inglobChangelog:
[GENERAL] [SECURITY] - Replace
glob@^7.0.0withtinyglobby@^0.2.15Test Plan:
pod installinrn-testerios-prebuild-related scripts will be run and tested via CI