Skip to content

Fix crash in URL constructor when URL has hash but no protocol#56379

Open
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:fix/url-constructor-null-safety
Open

Fix crash in URL constructor when URL has hash but no protocol#56379
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:fix/url-constructor-null-safety

Conversation

@Nedunchezhiyan-M
Copy link
Copy Markdown

@Nedunchezhiyan-M Nedunchezhiyan-M commented Apr 8, 2026

Summary

Fix a crash in the URL constructor when parsing URLs that contain a # but no :// separator (e.g., mailto:user@example.com#section).

The code splits on :// and accesses index [1] without checking if it exists, then calls .includes('/') on undefined, causing a TypeError.

Changelog:

[GENERAL] [FIXED] - Fix crash in URL constructor when URL contains hash but no protocol separator

Test Plan

  1. Create a URL with new URL('mailto:user@example.com#section') - should not throw
  2. Added unit test to verify URLs with hash but no :// don't crash
  3. Existing URL tests continue to pass

The URL constructor crashes when parsing a URL that contains a hash
but no "://" separator (e.g. "mailto:user@example.com#section").
The split on "://" returns undefined for index [1], and calling
.includes('/') on undefined throws a TypeError.

Added a null check before accessing the split result.
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 8, 2026

Hi @Nedunchezhiyan-M!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Nedunchezhiyan-M Nedunchezhiyan-M force-pushed the fix/url-constructor-null-safety branch from 8ba03d1 to a9c18a6 Compare April 8, 2026 19:59
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 10, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2026
@facebook-github-tools facebook-github-tools bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant