Fix crash in URL constructor when URL has hash but no protocol#56379
Fix crash in URL constructor when URL has hash but no protocol#56379Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Conversation
The URL constructor crashes when parsing a URL that contains a hash
but no "://" separator (e.g. "mailto:user@example.com#section").
The split on "://" returns undefined for index [1], and calling
.includes('/') on undefined throws a TypeError.
Added a null check before accessing the split result.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
8ba03d1 to
a9c18a6
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Fix a crash in the
URLconstructor when parsing URLs that contain a#but no://separator (e.g.,mailto:user@example.com#section).The code splits on
://and accesses index[1]without checking if it exists, then calls.includes('/')onundefined, causing aTypeError.Changelog:
[GENERAL] [FIXED] - Fix crash in URL constructor when URL contains hash but no protocol separator
Test Plan
new URL('mailto:user@example.com#section')- should not throw://don't crash