Skip to content

Fix FileReader.result TypeScript type to include null#56380

Open
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:fix/filereader-result-type-nullable
Open

Fix FileReader.result TypeScript type to include null#56380
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:fix/filereader-result-type-nullable

Conversation

@Nedunchezhiyan-M
Copy link
Copy Markdown

@Nedunchezhiyan-M Nedunchezhiyan-M commented Apr 8, 2026

Summary

The TypeScript declaration for FileReader.result is typed as string | ArrayBuffer, but the implementation (in Libraries/Blob/FileReader.js) returns ?ReaderResult which can be null. Per the WHATWG FileReader spec, result is null in the EMPTY and LOADING states.

This causes type mismatches when users check for null before using the result.

Changelog:

[GENERAL] [FIXED] - Fix FileReader.result TypeScript type to include null, matching the spec and implementation

Test Plan

  1. Verify that FileReader.result typed as string | ArrayBuffer | null matches the WHATWG spec
  2. Verify it matches the Flow source at Libraries/Blob/FileReader.js:178 which returns ?ReaderResult
  3. TypeScript consumers can now correctly check for null before using the result

The TypeScript declaration for FileReader.result is typed as
string | ArrayBuffer, but the actual implementation returns null
when no read operation has completed or when the read was aborted.
This matches the WHATWG FileReader spec where result is null in
the EMPTY and LOADING states.
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 8, 2026

Hi @Nedunchezhiyan-M!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Nedunchezhiyan-M Nedunchezhiyan-M force-pushed the fix/filereader-result-type-nullable branch from 655d038 to d5e7e3e Compare April 8, 2026 19:59
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 10, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2026
@facebook-github-tools facebook-github-tools bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant