Skip to content

Improve WebSocket error messages for CONNECTING state#56383

Open
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:fix/websocket-invalid-state-error-message
Open

Improve WebSocket error messages for CONNECTING state#56383
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:fix/websocket-invalid-state-error-message

Conversation

@Nedunchezhiyan-M
Copy link
Copy Markdown

@Nedunchezhiyan-M Nedunchezhiyan-M commented Apr 8, 2026

Summary

Replace opaque INVALID_STATE_ERR error messages in WebSocket's send() and ping() methods with descriptive messages that tell the developer what went wrong and which method was called. This matches the style used by browser WebSocket implementations.

Before: Error: INVALID_STATE_ERR
After: Error: Failed to execute 'send' on 'WebSocket': Still in CONNECTING state

Changelog:

[GENERAL] [CHANGED] - Improve WebSocket send() and ping() error messages when called in CONNECTING state

Test Plan

  1. Create a WebSocket and immediately call send() before the connection opens
  2. Verify the error message now reads "Failed to execute 'send' on 'WebSocket': Still in CONNECTING state"
  3. Same for ping() - verify the descriptive message appears

The send() and ping() methods throw "INVALID_STATE_ERR" which is
an opaque error code that doesn't tell the developer what went wrong.
Updated to descriptive messages that explain the actual issue,
matching the style used by browser WebSocket implementations.
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 8, 2026

Hi @Nedunchezhiyan-M!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Nedunchezhiyan-M Nedunchezhiyan-M force-pushed the fix/websocket-invalid-state-error-message branch from 9d09347 to c305232 Compare April 8, 2026 19:59
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 10, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2026
@facebook-github-tools facebook-github-tools bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant