Improve WebSocket error messages for CONNECTING state#56383
Improve WebSocket error messages for CONNECTING state#56383Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Conversation
The send() and ping() methods throw "INVALID_STATE_ERR" which is an opaque error code that doesn't tell the developer what went wrong. Updated to descriptive messages that explain the actual issue, matching the style used by browser WebSocket implementations.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
9d09347 to
c305232
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Replace opaque
INVALID_STATE_ERRerror messages in WebSocket'ssend()andping()methods with descriptive messages that tell the developer what went wrong and which method was called. This matches the style used by browser WebSocket implementations.Before:
Error: INVALID_STATE_ERRAfter:
Error: Failed to execute 'send' on 'WebSocket': Still in CONNECTING stateChangelog:
[GENERAL] [CHANGED] - Improve WebSocket send() and ping() error messages when called in CONNECTING state
Test Plan
send()before the connection opensping()- verify the descriptive message appears