Skip to content

Fix setLayoutAnimationEnabled assigning variable to itself#56387

Open
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:fix/layout-animation-set-enabled
Open

Fix setLayoutAnimationEnabled assigning variable to itself#56387
Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Nedunchezhiyan-M:fix/layout-animation-set-enabled

Conversation

@Nedunchezhiyan-M
Copy link
Copy Markdown

@Nedunchezhiyan-M Nedunchezhiyan-M commented Apr 8, 2026

Summary

setLayoutAnimationEnabled() in LayoutAnimation.js assigns isLayoutAnimationEnabled back to itself instead of the value parameter:

// Before (bug)
function setLayoutAnimationEnabled(value: boolean) {
  isLayoutAnimationEnabled = isLayoutAnimationEnabled; // no-op
}

// After (fixed)
function setLayoutAnimationEnabled(value: boolean) {
  isLayoutAnimationEnabled = value;
}

This makes the function a complete no-op, meaning LayoutAnimation can never be toggled at runtime once initialized from the feature flag.

Changelog:

[GENERAL] [FIXED] - Fix setLayoutAnimationEnabled not applying the value parameter

Test Plan

  1. Call LayoutAnimation.setLayoutAnimationEnabled(false) and verify layout animations are disabled
  2. Call LayoutAnimation.setLayoutAnimationEnabled(true) and verify they re-enable
  3. Previously both calls had no effect due to the self-assignment bug

setLayoutAnimationEnabled was assigning isLayoutAnimationEnabled
back to itself instead of the value parameter, making the function
a no-op. This meant LayoutAnimation could never be toggled at
runtime once initialized.
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 8, 2026

Hi @Nedunchezhiyan-M!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Nedunchezhiyan-M Nedunchezhiyan-M force-pushed the fix/layout-animation-set-enabled branch from c0ec9ec to f20529c Compare April 8, 2026 19:59
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 10, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2026
@facebook-github-tools facebook-github-tools bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant