Fix setLayoutAnimationEnabled assigning variable to itself#56387
Fix setLayoutAnimationEnabled assigning variable to itself#56387Nedunchezhiyan-M wants to merge 1 commit intofacebook:mainfrom
Conversation
setLayoutAnimationEnabled was assigning isLayoutAnimationEnabled back to itself instead of the value parameter, making the function a no-op. This meant LayoutAnimation could never be toggled at runtime once initialized.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
c0ec9ec to
f20529c
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
setLayoutAnimationEnabled()inLayoutAnimation.jsassignsisLayoutAnimationEnabledback to itself instead of thevalueparameter:This makes the function a complete no-op, meaning LayoutAnimation can never be toggled at runtime once initialized from the feature flag.
Changelog:
[GENERAL] [FIXED] - Fix setLayoutAnimationEnabled not applying the value parameter
Test Plan
LayoutAnimation.setLayoutAnimationEnabled(false)and verify layout animations are disabledLayoutAnimation.setLayoutAnimationEnabled(true)and verify they re-enable