fix: stricter files array in react-native's package.json#56407
Open
Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Open
fix: stricter files array in react-native's package.json#56407Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Conversation
See https://github.com/microsoft/react-native-macos/pull/2839/changes#r2850281910 `npm publish`, when reading this package.json will treat dirs in the files array as a recursive glob, while `yarn npm publish` (which react-native-macos uses) will not. However, explicitly adding the glob is compatible with both.
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
p: Microsoft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
See https://github.com/microsoft/react-native-macos/pull/2839/changes#r2850281910
npm publish, when reading this package.json will treat dirs in the files array as a recursive glob, whileyarn npm publish(which react-native-macos uses) will not. However, explicitly adding the glob is compatible with both.Changelog:
[GENERAL] [FIXED] - Use glob pattern in package json files array
Test Plan:
Tested in React Native macOS with npm pack