Skip to content

ISerialization methods should take in const jsi::Value& (#56410) #56410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsaichien wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

ISerialization methods should take in const jsi::Value& (#56410) #56410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-native/ReactCommon/jsi/jsi/jsi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ class JSI_EXPORT ISerialization : public ICast {
/// It returns a shared pointer of an opaque Serialized object that can be
/// deserialized multiple times. The lifetime of the Serialized object is not
/// tied to the lifetime of the original object.
virtual std::shared_ptr<Serialized> serialize(Value& value) = 0;
virtual std::shared_ptr<Serialized> serialize(const Value& value) = 0;

/// Given a Serialized object provided by \p serialized, deserialize it using
/// the structured clone algorithm into a JS value in the current runtime.
Expand All @@ -302,7 +302,7 @@ class JSI_EXPORT ISerialization : public ICast {
/// deserializeWithTransfer. The lifetime of the Serialized object is not tied
/// to the lifetime of the original object.
virtual std::unique_ptr<Serialized> serializeWithTransfer(
Value& value,
const Value& value,
const Array& transferList) = 0;

/// Using the structure clone algorithm, deserialize the object provided by \p
Expand All @@ -313,8 +313,8 @@ class JSI_EXPORT ISerialization : public ICast {
/// serialized data entirely and make the serialized objects in the current
/// runtime. Any transferred values in the serialized object will be owned by
/// the current runtime.
// This method returns an Array containing the deserialized values, where the
// first element is the value passed into serializeWithTransfer,
/// This method returns an Array containing the deserialized values, where
/// the first element is the value passed into serializeWithTransfer,
/// followed by all transferred values.
virtual Array deserializeWithTransfer(
std::unique_ptr<Serialized>& serialized) = 0;
Expand Down
Loading