Migrate begin/endEvent try/finally patterns to Systrace.trace (#56937)#56937
Closed
rubennorte wants to merge 2 commits into
Closed
Migrate begin/endEvent try/finally patterns to Systrace.trace (#56937)#56937rubennorte wants to merge 2 commits into
Systrace.trace (#56937)#56937rubennorte wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106073157. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
meta-codesync
Bot
changed the title
Systrace.traceSystrace.trace (#56937)
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 22, 2026
…book#56937) Summary: Migrates existing `Systrace.beginEvent` / `Systrace.endEvent` (and bare `beginEvent`/`endEvent`) try/finally blocks to the new `Systrace.trace` helper, which keeps the same semantics but is more concise. Other existing `beginEvent`/`endEvent` call sites are left untouched because they have `__DEV__` guards that do not wrap the entire body and would require additional restructuring. Changelog: [Internal] Reviewed By: javache Differential Revision: D106073157
rubennorte
force-pushed
the
export-D106073157
branch
from
a2db1db to
39020ca
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 22, 2026
…book#56937) Summary: Migrates existing `Systrace.beginEvent` / `Systrace.endEvent` (and bare `beginEvent`/`endEvent`) try/finally blocks to the new `Systrace.trace` helper, which keeps the same semantics but is more concise. Other existing `beginEvent`/`endEvent` call sites are left untouched because they have `__DEV__` guards that do not wrap the entire body and would require additional restructuring. Changelog: [Internal] Reviewed By: javache Differential Revision: D106073157
rubennorte
force-pushed
the
export-D106073157
branch
from
39020ca to
4fdba4d
Compare
Summary:
Adds a new `trace` helper to the `Systrace` module that wraps a function call between `beginEvent` and `endEvent`, ensuring the trace section is closed even if the function throws.
Usage:
```
Systrace.trace('name', () => {
// logic to trace
});
```
The implementation is guarded with `isEnabled()` and inlines `beginEvent`/`endEvent` so that the no-op path avoids redundant work when tracing is disabled.
Changelog:
[General][Added] - Add `Systrace.trace` helper that wraps a function with begin/end events using try/finally
Reviewed By: javache
Differential Revision: D106071568
…book#56937) Summary: Migrates existing `Systrace.beginEvent` / `Systrace.endEvent` (and bare `beginEvent`/`endEvent`) try/finally blocks to the new `Systrace.trace` helper, which keeps the same semantics but is more concise. Other existing `beginEvent`/`endEvent` call sites are left untouched because they have `__DEV__` guards that do not wrap the entire body and would require additional restructuring. Changelog: [Internal] Reviewed By: javache Differential Revision: D106073157
rubennorte
force-pushed
the
export-D106073157
branch
from
4fdba4d to
52b3488
Compare
|
This pull request has been merged in 3d50561. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates existing
Systrace.beginEvent/Systrace.endEvent(and barebeginEvent/endEvent) try/finally blocks to the newSystrace.tracehelper, which keeps the same semantics but is more concise.Other existing
beginEvent/endEventcall sites are left untouched because they have__DEV__guards that do not wrap the entire body and would require additional restructuring.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D106073157