Skip to content

Fix script_phases.sh error() helper: missing echo + arg truncation (fixes #56955) #56959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeSingh1 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Fix script_phases.sh error() helper: missing echo + arg truncation (fixes #56955) #56959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/react-native/scripts/react_native_pods_utils/script_phases.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@ cd "$RCT_SCRIPT_RN_DIR"
CODEGEN_CLI_PATH=""

error () {
echo "$1"
"[Codegen] $1" >> "${SCRIPT_OUTPUT_FILE_0}" 2>&1
# Print the full message (all positional args, space-separated) so multi-arg
# callers like find_node don't get truncated to just $1. Mirror the same
# message into SCRIPT_OUTPUT_FILE_0; the previous version was missing the
# leading `echo`, so the formatted string was instead being executed as a
# command and the shell error landed in the log file.
echo "$*"
echo "[Codegen] $*" >> "${SCRIPT_OUTPUT_FILE_0}" 2>&1
exit 1
}

Expand Down
Loading